-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use better default path on Flutter #665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expose defaultRealmName defaultStoragePath, defaultRealmPath props
Increase timeout for validating sessionStates
blagoev
requested review from
nielsenko,
fealebenpae,
nirinchev and
desistefanova
June 13, 2022 22:08
nielsenko
reviewed
Jun 14, 2022
nielsenko
approved these changes
Jun 14, 2022
desistefanova
approved these changes
Jun 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces better default paths on Flutter.
/// On Flutter Android and iOS this is the application's data directory.
/// On Flutter Windows this is the
C:\Users\username\AppData\Roaming\app_name
directory./// On Flutter macOS this is the
/Users/username/Library/Containers/app_name/Data/Library/Application Support
directory./// On Flutter Linux this is the
/home/username/.local/share/app_name
directory./// On Dart standalone Windows, macOS and Linux this is the current directory.
fixes #450
This also reintroduces
Configuration.defaultRealmName
andConfiguration.defaultRealmPath
which the user can set once and all realms will use these fields by default.This also introduces
Configuration.defaultStoragePath
static getter which point to the platform specific writable application directory on Flutter and the current directory on Dart.