Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDART-1031: Disable codesign for apple binaries #1694

Merged
merged 3 commits into from
May 27, 2024
Merged

RDART-1031: Disable codesign for apple binaries #1694

merged 3 commits into from
May 27, 2024

Conversation

nirinchev
Copy link
Member

Fixes #1679

@nirinchev nirinchev requested a review from fealebenpae May 27, 2024 13:40
@cla-bot cla-bot bot added the cla: yes label May 27, 2024
@nirinchev nirinchev requested a review from nielsenko May 27, 2024 13:40
nielsenko
nielsenko approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 9255971619

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.208%
Totals Coverage Status
Change from base Build 9254002300: 0.0%
Covered Lines: 5890
Relevant Lines: 6754
💛 - Coveralls

@nirinchev nirinchev merged commit 7384897 into main May 27, 2024
42 of 49 checks passed
@nirinchev nirinchev deleted the ni/disable-codesign branch May 27, 2024 14:56
nirinchev added a commit that referenced this pull request May 27, 2024
@nirinchev
Merge branch 'main' into ni/progress-notifications
c7ff71f 
* main:
  RDART-1031: Disable codesign for apple binaries (#1694)
  RDART-1038: Drop keep alive hack (#1691)
@flawnn flawnn mentioned this pull request May 28, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter Build Issue MacOS - Invalid Code Signing Entitlements (while uploading to Testflight)
3 participants
@nirinchev @fealebenpae @nielsenko