-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDART-964: Add PrivacyInfo.xcprivacy for iOS and macOS #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsenko
changed the title
Add PrivacyInfo.xcprivacy for iOS and macOS
RDART-964: Add PrivacyInfo.xcprivacy for iOS and macOS
Apr 24, 2024
nielsenko
force-pushed
the
kn/privacy-manifest
branch
from
April 24, 2024 14:54
fe7d460
to
e4008e9
Compare
nirinchev
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, should we symlink those manifests or duplicating them is fine?
I would prefer not, for now. |
nielsenko
force-pushed
the
kn/privacy-manifest
branch
from
April 29, 2024 15:19
e4008e9
to
6a6ded9
Compare
nielsenko
added a commit
that referenced
this pull request
May 2, 2024
nirinchev
added a commit
that referenced
this pull request
May 27, 2024
* main: (37 commits) RDART-930: Refactor handles (#1550) Forgot to show GeoPolygon Add vNext Changelog header (#1687) [Release 2.3.0] (#1686) RDART-1028: Use Zone.current.bindUnaryCallbackGuarded for RawReceivePort.handler (#1683) RDART-1021: Wire up some basic dynamic setting and change notifications (#1669) RDART-1022: Drop x86 as target (#1682) RDART-1034: Update realm-core to v14.7.0 (#1681) Skip select test RDART-1018: Fix badly generated _fromJson (#1664) Add vNext Changelog header (#1660) [Release 2.2.1] (#1659) Update CHANGELOG.md RDART-1016: Cleanup iOS podspec (#1658) Add vNext Changelog header (#1655) [Release 2.2.0] (#1654) RDART-1015: Update core to v14.6.2 (#1651) RDART-950: Update nullability annotations for base url API (#1652) RDART-964: Add PrivacyInfo.xcprivacy for iOS and macOS (#1646) RDART-1014: Bump required sdk version to ^3.3.0 (#1648) ... # Conflicts: # CHANGELOG.md # packages/realm_dart/lib/src/native/realm_core.dart # packages/realm_dart/src/realm-core # packages/realm_dart/test/realm_test.dart # packages/realm_dart/test/session_test.dart # packages/realm_dart/test/test.dart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds privacy manifests to our iOS and macOS plugins.
While we only need to update the plugins listed here for now (ie RealmSwift), the wording of the page:
suggests that the list of things for which this is required is just an arbitrary cutoff rather than a conceptual distinction, so it seems safest to just assume the list will grow over time and do this for the realm flutter package as well. To be honest I don't trust that Apple got the list right.
Note that we are following the standard Flutter / Cocoapods implementation which has the following caveat:
Source: flutter/packages@c5349bc
The flutter repo is tracking the approach here.
As to why the we (and the flutter team) add
_privacy
to the resource bundle id seeflutter/packages#5846 (comment)
The actual privacy manifest files are lifted from the realm-swift repo.
I'll quote the commit message, as to. why it looks as it does:
Fixes: #1551
Fixes: #1629
Fixes: #1630