Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SyncResolveError values #1131

Merged
merged 7 commits into from
Jan 30, 2023
Merged

Fix SyncResolveError values #1131

merged 7 commits into from
Jan 30, 2023

Conversation

desistefanova
Copy link
Contributor

@desistefanova desistefanova commented Jan 30, 2023 •
edited
Loading

SyncResolveError enum improvement.
Added error code numbers according to the codes in C-API - realm/realm-core#6186

@cla-bot cla-bot bot added the cla: yes label Jan 30, 2023
@desistefanova desistefanova marked this pull request as ready for review January 30, 2023 10:38
@blagoev
Copy link
Contributor

blagoev commented Jan 30, 2023 •
edited
Loading

@desistefanova is this really fixing #676. The discussion there does not mention anything we are doing this PR. To me this issue should be closed and this PR is just an enhancement to the error information we provide

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4042964796

  • -1 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 89.288%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/configuration.dart 1 2 50.0%
Totals Coverage Status
Change from base Build 4042717374: 0.3%
Covered Lines: 3009
Relevant Lines: 3370
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 30, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4045216239

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 89.102%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/configuration.dart 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
lib/src/configuration.dart 7 62.5%
Totals Coverage Status
Change from base Build 4044910243: -0.1%
Covered Lines: 3025
Relevant Lines: 3395
💛 - Coveralls

blagoev
blagoev suggested changes Jan 30, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@desistefanova desistefanova requested a review from blagoev January 30, 2023 12:41
blagoev
blagoev suggested changes Jan 30, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
nielsenko
nielsenko reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a question about the actual int codes, but otherwise LGTM

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
lib/src/session.dart Show resolved Hide resolved
@blagoev blagoev merged commit 2f748a5 into main Jan 30, 2023
@blagoev blagoev deleted the enable_test_syncErrorHandler.resolve branch January 30, 2023 19:20
desistefanova added a commit that referenced this pull request Feb 1, 2023
@desistefanova
Fix SyncResolveError values (#1131)
c78b076 
* Enable test "Sync Network Resolve Error" and add values instedf of indexes

* Update changelog

* Update changelog

* Update changelog

* Fix changelog

* Fix changelog
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blagoev blagoev blagoev approved these changes

@nielsenko nielsenko nielsenko approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

Assignees

@desistefanova desistefanova

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@desistefanova @blagoev @coveralls @nielsenko