Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nocopy version of index::find_all #81

Closed
wants to merge 2 commits into from

Conversation

astigsen
Copy link
Contributor

@astigsen astigsen commented Apr 5, 2013

This makes it possible to find all matches in string index, without having to copy them (if there are multiple matches, you get a ref to the underlying column instance).

@rrrlasse @kspangsege

@ghost ghost assigned rrrlasse Apr 5, 2013

// In most cases the row list will just be an array but there
// might be so many matches that it has branched into a column
if (!sub_isnode) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the last 5 lines of the "if" and the "else" is identical - suggest to move it below the if-else statement.

@kspangsege
Copy link
Contributor

Please pull #67 and resolve the conflicts if there are any.

@bmunkholm bmunkholm closed this May 8, 2013
@astigsen
Copy link
Contributor Author

astigsen commented May 9, 2013

@bmunkholm any reason that this pull request was closed without merging?

@bmunkholm
Copy link
Contributor

Already merged by another merge :-)

Mvh
/Brian

Den 09/05/2013 kl. 18.37 skrev astigsen [email protected]:

@bmunkholm any reason that this pull request was closed without merging?


Reply to this email directly or view it on GitHub.

@astigsen
Copy link
Contributor Author

astigsen commented May 9, 2013

ok :-)

On Thu, May 9, 2013 at 9:40 AM, bmunkholm [email protected] wrote:

Already merged by another merge :-)

Mvh
/Brian

Den 09/05/2013 kl. 18.37 skrev astigsen [email protected]:

@bmunkholm any reason that this pull request was closed without merging?


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com//pull/81#issuecomment-17674732
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants