Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore wait_for_baas.sh script #8027

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Restore wait_for_baas.sh script #8027

merged 1 commit into from
Sep 18, 2024

Conversation

jbreams
Copy link
Contributor

@jbreams jbreams commented Sep 18, 2024

What, How & Why?

Fixes the install_baas.sh script used for local development.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@cla-bot cla-bot bot added the cla: yes label Sep 18, 2024
danieltabacaru
danieltabacaru approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@danieltabacaru danieltabacaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jbreams jbreams merged commit a3cdfbb into master Sep 18, 2024
6 of 11 checks passed
@jbreams jbreams deleted the jbr/restore_wait_for_baas branch September 18, 2024 15:54
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danieltabacaru danieltabacaru danieltabacaru approved these changes

Assignees

@jbreams jbreams

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbreams @danieltabacaru