RCORE-2224 clean up an unused read lock on subscription sets #7949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
reviewed
Aug 2, 2024
test/test_sync_subscriptions.cpp
Outdated
| Query query_a(read_tr->get_table("class_a")); | ||
| query_a.greater_equal(fixture.bar_col, int64_t(1)); | ||
|
|
||
| size_t num_versions_before_subscription = fixture.db->get_number_of_versions(); |
There was a problem hiding this comment.
Windows build failures are because get_number_of_versions is a int64_t, not size_t.
tgoyne
approved these changes
Aug 2, 2024
Pull Request Test Coverage Report for Build james.stone_583Details
💛 - Coveralls |
danieltabacaru
approved these changes
Aug 5, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this unnecessary version pin when inspecting the version locks while downloading a large bootstrap. Releasing it should improve resource utilization, especially for large sync'd Realms. I'm not sure how long SDKs hold onto the subscriptions for so this change may or may not help in practice.
Fixes #7946
☑️ ToDos
bindgen/spec.yml, if public C++ API changed