Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2187 Fix a test failure when the default log level is too low #7943

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented Aug 1, 2024

This test was relying on the default log level being high enough that the expected messages would actually be logged.

This test was relying on the default log level being high enough that the
expected messages would actually be logged.
@tgoyne tgoyne added no-changelog no-jira-ticket Skip checking the PR title for Jira reference labels Aug 1, 2024
@tgoyne tgoyne self-assigned this Aug 1, 2024
@cla-bot cla-bot bot added the cla: yes label Aug 1, 2024
@tgoyne tgoyne requested a review from jbreams August 2, 2024 17:32
Copy link
Contributor

@jbreams jbreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yep, this was on my list of things to fix. Can you tag RCORE-2187 when you merge?

@tgoyne tgoyne changed the title Fix a test failure when the default log level is too low RCORE-2187 Fix a test failure when the default log level is too low Aug 2, 2024
@tgoyne tgoyne merged commit 854ea7e into master Aug 2, 2024
56 checks passed
@tgoyne tgoyne deleted the tg/test-log-level branch August 2, 2024 20:26
@tgoyne tgoyne removed the no-jira-ticket Skip checking the PR title for Jira reference label Aug 2, 2024
@jbreams
Copy link
Contributor

jbreams commented Aug 2, 2024

Thanks for taking care of this!

@github-actions github-actions bot mentioned this pull request Aug 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants