RCORE-2096 Trim trailing slashes from base urls to prevent 404 errors #7791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieltabacaru
approved these changes
Jun 10, 2024
src/realm/object-store/sync/app.cpp
Outdated
| @@ -157,6 +157,24 @@ HttpHeaders get_request_headers(const std::shared_ptr<User>& user, RequestTokenT | |||
| return headers; | |||
| } | |||
|
|
|||
| std::string trim_base_url(std::string base_url) | |||
| { | |||
| while (base_url.back() == '/') { | |||
There was a problem hiding this comment.
I know the base_url should not be empty, but it's undefined behaviour to call back() if empty() is true. we should add a guard.
Pull Request Test Coverage Report for Build jonathan.reams_3267Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build jonathan.reams_3271Details
💛 - Coveralls |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This fixes a gotcha where if you set your base url to "https://example.com/" instead of "https://example.com" it will be interpretted as "https://example.com//path/to/app" which results in a 404 error from the server.
☑️ ToDos
bindgen/spec.yml, if public C++ API changed