Optimize IntegerNode::find_first_local #7772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you are just testing one element, use simple compare instead of leaf->find_first. This will speed up queries where secondary nodes are IntegerNodes.
Pull Request Test Coverage Report for Build jorgen.edelbo_285Details
💛 - Coveralls |
|
PS: we need this for integer compression too. |
ironage
reviewed
Jun 4, 2024
src/realm/query_engine.hpp
Outdated
| @@ -425,6 +425,17 @@ class IntegerNode : public IntegerNodeBase<LeafType> { | |||
|
|
|||
| size_t find_first_local(size_t start, size_t end) override | |||
| { | |||
| TConditionFunction c; | |||
There was a problem hiding this comment.
All our operators shouldn't have anything going on in the constructor, but can you move this to inside the scope where it is used so that one isn't constructed/destructed when it isn't used? (Hopefully the compiler knows that this is a no-op but you never know)
ironage
reviewed
Jun 4, 2024
src/realm/query_engine.hpp
Outdated
| @@ -425,6 +425,17 @@ class IntegerNode : public IntegerNodeBase<LeafType> { | |||
|
|
|||
| size_t find_first_local(size_t start, size_t end) override | |||
| { | |||
| TConditionFunction c; | |||
| if (end - start == 1) { | |||
There was a problem hiding this comment.
why not move the end - start == 1 case into the Array's find_first method itself? Then all call sites will benefit from the optimization.
There was a problem hiding this comment.
Yes - that might actually be a better idea
ironage
reviewed
Jun 4, 2024
Pull Request Test Coverage Report for Build jorgen.edelbo_286Details
💛 - Coveralls |
ironage
approved these changes
Jun 6, 2024
| return to_size_t(state.m_state); | ||
| else | ||
| return not_found; | ||
| return static_cast<size_t>(state.m_state); |
There was a problem hiding this comment.
nit: QueryStateFindFirst.m_state is already a size_t, so no cast is necessary here.
There was a problem hiding this comment.
I hate being caught in this - but it was copied from somewhere else :-)
I will fix this later
|
Some benchmark improvement: it is queries like "age > 20 && height > 200" that benefit from this. |
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are just testing one element, use simple compare instead of leaf->find_first. This will speed up queries where secondary nodes are IntegerNodes.
What, How & Why?
☑️ ToDos
bindgen/spec.yml, if public C++ API changed