RCORE-2151 Fix race in schema migration tests #7766
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Some of the schema migration tests test the recovery of subscriptions and objects after a schema migration. This requires that the subscriptions and objects are committed when the synchronization session is paused so nothing is uploaded.
SyncSession::pause()
is used for this, but pause is an async operation so there is a race between pausing the session and uploading the data and subscriptions.SyncSession::shutdown_and_wait()
is used instead.Fixes #7767.
☑️ ToDos
[ ] 📝 Changelog update[ ] C-API, if public C++ API changed[ ]bindgen/spec.yml
, if public C++ API changed