RCORE-2150 Include originating client reset error message when reporting auto client reset failures #7761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2024 12:02
Pull Request Test Coverage Report for Build michael.wilkersonbarker_1135Details
💛 - Coveralls |
danieltabacaru
approved these changes
Jun 3, 2024
jbreams
reviewed
Jun 3, 2024
| @@ -408,7 +408,7 @@ class SyncSession : public std::enable_shared_from_this<SyncSession> { | |||
|
|
|||
| void download_fresh_realm(const sync::SessionErrorInfo& error_info) | |||
| REQUIRES(!m_config_mutex, !m_state_mutex, !m_connection_state_mutex); | |||
| void handle_fresh_realm_downloaded(DBRef db, StatusWith<sync::SessionErrorInfo> error_info, | |||
| void handle_fresh_realm_downloaded(DBRef db, Status result, const sync::SessionErrorInfo& cr_error_info, | |||
There was a problem hiding this comment.
Because I needed access to both the Status that just occurred as well as the SessionErrorInfo for the originating client reset error. When it was using the StatusWith, you would only have access to one or the other...
jbreams
approved these changes
Jun 3, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
The originating client reset error was not included in the error reported to the client as part of the changes from #7649. This PR adds the originating client reset error to the error message included with the
AutoClientResetFailederror reported to the client.Fixes #7760
☑️ ToDos
* [ ] C-API, if public C++ API changed* [ ]bindgen/spec.yml, if public C++ API changed