Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2145: Output InRealmHistory when compacting #7753

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented May 30, 2024

This will ensure that the current history version is written, so that an upgrade will not be required when opening the file.

What, How & Why?

Fixes #7747

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

This will ensure that the current history version is written, so that
an upgrade will not be required when opening the file.
Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lovely corner case.

Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_278

Details

  • 33 of 33 (100.0%) changed or added relevant lines in 2 files are covered.
  • 24 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.03%) to 90.837%

Files with Coverage Reduction New Missed Lines %
src/realm/sync/noinst/client_impl_base.cpp 1 82.51%
src/realm/util/file.cpp 1 78.73%
src/realm/util/serializer.cpp 1 90.43%
test/test_index_string.cpp 1 93.48%
src/realm/object-store/shared_realm.cpp 2 91.89%
src/realm/table_view.cpp 2 92.99%
src/realm/sync/client.cpp 3 91.17%
src/realm/sync/noinst/server/server_history.cpp 3 63.51%
src/realm/sync/transform.cpp 3 60.92%
test/fuzz_group.cpp 3 47.85%
Totals Coverage Status
Change from base Build 2356: 0.03%
Covered Lines: 214464
Relevant Lines: 236098

💛 - Coveralls

@jedelbo jedelbo merged commit df4a632 into master May 31, 2024
25 of 26 checks passed
@jedelbo jedelbo deleted the je/RCORE-2145 branch May 31, 2024 14:19
@github-actions github-actions bot mentioned this pull request May 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Realm::compact writes incorrect file format version
2 participants