Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2131: Don't throw immediately when convertion of string to number fails #7715

Merged
merged 2 commits into from
May 22, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented May 21, 2024

The parser will throw later anyway if the comparison cannot be done.

What, How & Why?

Fixes #7714

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

The parser will throw later anyway if the comparison cannot be done.
@cla-bot cla-bot bot added the cla: yes label May 21, 2024
@jedelbo jedelbo requested a review from ironage May 21, 2024 14:22
@jedelbo jedelbo changed the title Don't throw immediately when convertion of string to number fails RCORE-2131: Don't throw immediately when convertion of string to number fails May 21, 2024
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is passing.
See test: C API - queries::query::interpolate all types::type mismatch

@jedelbo
Copy link
Contributor Author

jedelbo commented May 22, 2024

@ironage damn this is a rabbit hole. We are not very consistent in when we throw InvalidQueryArgError and when it is just InvalidQueryError.

Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_263

Details

  • 16 of 22 (72.73%) changed or added relevant lines in 2 files are covered.
  • 51 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.808%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/parser/driver.cpp 14 20 70.0%
Files with Coverage Reduction New Missed Lines %
src/realm/mixed.cpp 1 86.46%
src/realm/query_expression.hpp 1 93.81%
src/realm/sync/noinst/server/server.cpp 1 73.96%
src/realm/sync/noinst/server/server_history.cpp 1 63.7%
src/realm/util/serializer.cpp 1 90.43%
src/realm/uuid.cpp 1 98.48%
test/fuzz_tester.hpp 1 57.73%
test/test_dictionary.cpp 1 99.83%
src/realm/array_blobs_big.cpp 2 98.58%
src/realm/cluster.cpp 2 75.6%
Totals Coverage Status
Change from base Build 2326: 0.02%
Covered Lines: 214763
Relevant Lines: 236503

💛 - Coveralls

@jedelbo jedelbo merged commit 3648014 into master May 22, 2024
37 checks passed
@jedelbo jedelbo deleted the je/convert-string branch May 22, 2024 13:49
@fealebenpae fealebenpae mentioned this pull request May 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator IN behaviour
2 participants