-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload also the realm file when the fuzzer fails #7700
Upload also the realm file when the fuzzer fails #7700
Conversation
Pull Request Test Coverage Report for Build nicola.cabiddu_1721Details
💛 - Coveralls |
bump @michael-wb and @jsflax |
evergreen/config.yml
Outdated
@@ -431,6 +431,7 @@ functions: | |||
if ls crash-*> /dev/null 2>&1; then | |||
echo "Found crash file" | |||
mv crash-* realm-fuzzer-crash.txt | |||
mv fuzz-test.realm fuzzer_realm.realm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you renaming the file from fuzz-test.realm
to fuzzer_realm.realm
and then back after it has been uploaded?
Was there a problem uploading the file with the original filename?
Or, if you are trying to rename the file that is uploaded, you can use the remote_file
parameter to specify the new file name when it is uploaded instead of renaming the file explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, the realm file we use for the fuzzer is never deleted, so it is always reused (cycle after cycle). If I got a crash file, I know there is a crash, so I am uploading the crash report and the realm, in order to avoid uploading for every cycle the realm file, I am just renaming it.
I am not sure, if there is a better strategy. So essentially, I only need to upload the file if there is a failure.
evergreen/config.yml
Outdated
local_file: 'realm-core/build/test/realm-fuzzer/fuzz-realm.realm' | ||
remote_file: '${project}/${branch_name}/${task_id}/${execution}/fuzz-realm.realm' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be fuzzer_realm.realm
, since you just renamed the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for making the updates
What, How & Why?
Upload also the realm file if the fuzzer fails, in order to reply the fuzzer locally using the input crash file and apply it to the same input file.
☑️ ToDos
bindgen/spec.yml
, if public C++ API changed