Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two columns with the same name #77

Merged
merged 3 commits into from
Apr 2, 2013
Merged

Two columns with the same name #77

merged 3 commits into from
Apr 2, 2013

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Apr 2, 2013

@ghost ghost assigned kspangsege Apr 2, 2013
@kspangsege
Copy link
Contributor

Why does this pull-request also contain a new benchmark program?
Is it intentional?

(please make branches to avoid this in the future)

@kneth
Copy link
Contributor Author

kneth commented Apr 2, 2013

Oh yeah, the benchmark program is unrelated and should have been in a separate branch.

@kspangsege
Copy link
Contributor

So do you want them to me merged anyway? If not, you have to do something about it. I cannot pick and choose from this pull request.

@kneth
Copy link
Contributor Author

kneth commented Apr 2, 2013

The benchmark is quite nice to have - we once had an issue with creating index on large tables.

@kspangsege
Copy link
Contributor

I'll take that as "Yes, please also merge the benchmark".

kspangsege added a commit that referenced this pull request Apr 2, 2013
Two columns with the same name
@kspangsege kspangsege merged commit 9f14938 into realm:master Apr 2, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants