Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2005: Include nested path in 'OutOfBounds' error message #7489

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Mar 18, 2024

What, How & Why?

Fixes #7438

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

coveralls-official bot commented Mar 18, 2024

Pull Request Test Coverage Report for Build jorgen.edelbo_150

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • 58 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.818%

Files with Coverage Reduction New Missed Lines %
src/realm/index_string.hpp 1 93.68%
src/realm/sync/network/network.cpp 1 89.86%
test/test_index_string.cpp 1 94.63%
test/test_table.cpp 1 99.6%
src/realm/query_expression.hpp 2 93.68%
src/realm/util/file.cpp 2 81.32%
src/realm/collection_parent.cpp 3 93.98%
src/realm/sort_descriptor.cpp 3 93.8%
src/realm/sync/client.cpp 3 91.07%
src/realm/util/future.hpp 3 95.98%
Totals Coverage Status
Change from base Build 2144: 0.02%
Covered Lines: 242907
Relevant Lines: 264552

💛 - Coveralls

Copy link
Member

@nicola-cab nicola-cab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jedelbo jedelbo merged commit 743894b into master Mar 19, 2024
33 of 37 checks passed
@jedelbo jedelbo deleted the je/out-of-bounds branch March 19, 2024 11:29
nirinchev added a commit that referenced this pull request Mar 21, 2024
* master:
  update release note
  prepare v14.4.0
  sets not allowed at storage level inside mixed (#7502)
  🔄 Synced file(s) with realm/ci-actions (#7481)
  RCORE-1982 Opening realm with cached user while offline results in fatal error and session does not retry connection (#7469)
  RCORE-2008 Bump baas version (#7499)
  RCORE-2027: Setting log callback should not override existing log level hierarchy (#7494)
  Derive correct ubuntu version on linuxmint (#7471)
  Include nested path in 'OutOfBounds' error message (#7489)
nirinchev added a commit that referenced this pull request Mar 22, 2024
* master:
  update release note
  prepare v14.4.0
  sets not allowed at storage level inside mixed (#7502)
  🔄 Synced file(s) with realm/ci-actions (#7481)
  RCORE-1982 Opening realm with cached user while offline results in fatal error and session does not retry connection (#7469)
  RCORE-2008 Bump baas version (#7499)
  RCORE-2027: Setting log callback should not override existing log level hierarchy (#7494)
  Derive correct ubuntu version on linuxmint (#7471)
  Include nested path in 'OutOfBounds' error message (#7489)
  fix depth for nested collections set to 4 in debug mode (#7486)
  Set the minimum buffer size in Group::write() to be equal to the page size (#7492)
  Update the parent's content version when bumping it in a nested collection (#7470)
  release notes
  core v14.3.0 (#7482)
  RCORE-2007 Added Resumption delay configuration to SyncClientTimeouts (#7441)
  Improve performance of aggregate operations on empty dictionaries (#7418)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include nested path in OutOfBounds error messages
2 participants