Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bindgen] commander dependency upgraded #7292

Merged
merged 3 commits into from
Jan 26, 2024
Merged

[bindgen] commander dependency upgraded #7292

merged 3 commits into from
Jan 26, 2024

Conversation

kraenhansen
Copy link
Member

@kraenhansen kraenhansen commented Jan 25, 2024 •
edited
Loading

What, How & Why?

This upgrades the dependency on @commander-js/extra-typings and adds a missing peer dependency on commander.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@cla-bot cla-bot bot added the cla: yes label Jan 25, 2024
@kraenhansen kraenhansen requested a review from takameyer January 25, 2024 12:21
@kraenhansen kraenhansen requested a review from jedelbo January 25, 2024 12:23
@kraenhansen kraenhansen mentioned this pull request Jan 25, 2024
Draft
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build kraen.hansen_48

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 91.846%
Totals Coverage Status
Change from base Build 1990: 0.009%
Covered Lines: 232868
Relevant Lines: 253543
💛 - Coveralls

@kraenhansen kraenhansen merged commit 683e868 into master Jan 26, 2024
34 of 35 checks passed
@kraenhansen kraenhansen deleted the kh/bindgen/commander-upgraded branch January 26, 2024 16:01
@kraenhansen kraenhansen mentioned this pull request Jan 27, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jedelbo jedelbo jedelbo approved these changes

@takameyer takameyer Awaiting requested review from takameyer

Assignees

@kraenhansen kraenhansen

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraenhansen @jedelbo