Harmonize check on class name length #7175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedelbo
force-pushed
the
je/RCORE-1896
branch
from
2652252 to
2283bac
Compare
jedelbo
force-pushed
the
je/RCORE-1896
branch
from
2283bac to
9e85c15
Compare
Pull Request Test Coverage Report for Build jorgen.edelbo_1
💛 - Coveralls |
jbreams
reviewed
Dec 1, 2023
|
@jbreams do you think this PR is in such a good shape that you would be able to actually approve it? 😄 |
|
I hope you agree that the check actually was wrong before. |
| @@ -293,6 +296,7 @@ class Group : public ArrayParent { | |||
| using TableNameBuffer = std::array<char, max_table_name_length>; | |||
| static StringData class_name_to_table_name(StringData class_name, TableNameBuffer& buffer) | |||
| { | |||
| REALM_ASSERT(class_name.size() <= max_class_name_length); | |||
There was a problem hiding this comment.
should we add a similar assertion to table_name_to_class_name?
There was a problem hiding this comment.
I don't think there would be a point in that. It just returns a substring.
There was a problem hiding this comment.
yes, but table_name is not supposed to have more than 63 characters
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| ### Fixed | |||
| * <How do the end-user experience this issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?) | |||
| * Update existing std exceptions thrown by the Sync Client to use Realm exceptions. ([#6255](https://github.com/realm/realm-core/issues/6255), since v10.2.0) | |||
| * Having a class name of length 57 would make client reset crash ([#7176](https://github.com/realm/realm-core/issues/7176), since v10.0.0) | |||
There was a problem hiding this comment.
is it that a class name of length 57 (63-6) should be allowed whereas before it was up to 56? I think this should be mentioned because it is not clear what this is fixing.
danieltabacaru
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fixes #7177
☑️ ToDos
bindgen/spec.yml, if public C++ API changed