Allow collections of non-embedded objects in asymmetric objects #7003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/asymmetric-object-list
branch
from
8d412d0 to
5a62526
Compare
Pull Request Test Coverage Report for Build github_pull_request_277462
💛 - Coveralls |
tgoyne
force-pushed
the
tg/asymmetric-object-list
branch
2 times, most recently
from
4422de3 to
fc51de8
Compare
| @@ -2916,17 +2956,26 @@ TEST_CASE("flx: data ingest", "[sync][flx][data ingest][baas]") { | |||
|
|
|||
| auto table = realm->read_group().get_table("class_Asymmetric"); | |||
| REQUIRE(table->size() == 0); | |||
|
|
|||
| auto documents = get_documents(*realm->config().sync_config->user, "Asymmetric", 100); | |||
| for (int i = 0; i < 100; ++i) { | |||
There was a problem hiding this comment.
nit: use the container size (i.e, obj_ids.size()) (+ in some other places below)
| realm->commit_transaction(); | ||
|
|
||
| wait_for_upload(*realm); | ||
| wait_for_download(*realm); | ||
|
|
||
| auto table = realm->read_group().get_table("class_Asymmetric"); | ||
| REQUIRE(table->size() == 0); | ||
|
|
||
| auto documents = get_documents(*realm->config().sync_config->user, "Asymmetric", 2); | ||
| check_document(documents, foo_obj_id, {{"embedded obj", BsonDocument{{"value", "foo"}}}}); |
There was a problem hiding this comment.
should we check the second doc was created as well?
test/object-store/sync/flx_sync.cpp
Outdated
| @@ -2864,17 +2903,19 @@ TEST_CASE("flx: data ingest", "[sync][flx][data ingest][baas]") { | |||
| Object::create(c, realm, "Asymmetric", std::any(AnyDict{{"_id", foo_obj_id}, {"location", "foo"s}})); | |||
| Object::create(c, realm, "Asymmetric", std::any(AnyDict{{"_id", bar_obj_id}, {"location", "bar"s}})); | |||
| realm->commit_transaction(); | |||
| wait_for_upload(*realm); | |||
|
|
|||
| auto documents = get_documents(*realm->config().sync_config->user, "Asymmetric", 2); | |||
There was a problem hiding this comment.
you should wait for upload before getting the documents. This works too because sync is not stopped, but you are querying the server unnecessarily (should be added in some other places below as well).
There was a problem hiding this comment.
Waiting for the upload to complete before polling doesn't really change how many times we poll. Upload completion happens about a quarter of the way through the time to when the documents are visible for asymmetric sync (and about 1% of the way for non-asymmetric).
danieltabacaru
approved these changes
Sep 28, 2023
tgoyne
force-pushed
the
tg/asymmetric-object-list
branch
from
fc51de8 to
1426620
Compare
michael-wb
approved these changes
Sep 28, 2023
tgoyne
force-pushed
the
tg/asymmetric-object-list
branch
2 times, most recently
from
be58eae to
b54fe1b
Compare
It's unclear if this actually caused any problems, but there were a number of places where we were deleting Realm files while they were in use due to copying a TestFile and then deleting the copy when we actually wanted to copy the config.
The schema validation checks forbidding this were removed in #6981, but Table also had its own validation.
tgoyne
force-pushed
the
tg/asymmetric-object-list
branch
from
b54fe1b to
8278d2b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema validation checks forbidding this were removed in #6981, but Table
also had its own validation. Most of the changes here are just making the asymmetric sync tests verify that the expected documents are actually created on the server.