Add an evergreen job to validate that all installed headers build #6954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had a few issues with headers being added as dependencies of an installed header but not being installed, so add a CI job that validates that all installed headers can be compiled with only the other installed headers available. This also catches some incidental missing header inclusions where a header failes to include everything it depends on. Only runs on macOS since Cocoa seems to be the only SDK which relies on this being valid.
fealebenpae
approved these changes
Sep 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a few issues with headers being added as dependencies of an installed header but not being installed, so add a CI job that validates that all installed headers can be compiled with only the other installed headers available. This also catches some incidental missing header inclusions where a header failes to include everything it depends on.
Only runs on macOS since Cocoa seems to be the only SDK which relies on this being valid.