Add a test for TLS error reporting and fix some problems #6938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/tls-error-reporting
branch
8 times, most recently
from
5adb7c1 to
a4d5cda
Compare
michael-wb
approved these changes
Sep 9, 2023
ObjectStore requires Security.framework for the keychain functionality even if Sync is using OpenSLL.
With SecureTransport only a single error code was reported as the TLS handshake failing, but actually every error code with the secure transport error category indicates that. With OpenSSL things were worse: it had a specific list of error messages that indicate a TLS error. This didn't actually work, as the error message wasn't being populated correctly and TLS errors would end up with errors like "RSA lib" rather than what the code was checking for (and these useless errors were forwarded on to the SDK).
tgoyne
force-pushed
the
tg/tls-error-reporting
branch
from
a4d5cda to
fb1d9b0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With SecureTransport only a single error code was reported as the TLS handshake failing, but actually every error code with the secure transport error category indicates that.
With OpenSSL things were worse: it had a specific list of error messages that indicate a TLS error. This didn't actually work, as the error message wasn't being populated correctly and TLS errors would end up with errors like "RSA lib" rather than what the code was checking for (and these useless errors were forwarded on to the SDK).