Don't duplicate error messages for SyncError #6774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SystemError is used in two places: as a base class for SyncError, and for filesystem errors. Filesystem errors don't include the actual error message and need it appended, but sync errors do and appending the message from the error code just results in it being duplicated.
tgoyne
commented
Jul 7, 2023
| @@ -1034,7 +1034,7 @@ void SimpleReporter::fail(const TestContext& context, const char* file, long lin | |||
| if (m_report_progress) { | |||
| m_error_messages.push_back(msg); | |||
| } | |||
| context.thread_context.report_logger.info(msg.c_str()); | |||
| context.thread_context.report_logger.info("%1", msg.c_str()); | |||
There was a problem hiding this comment.
The first argument to info() is a format string, so this was broken if the message contained %.
nicola-cab
pushed a commit
that referenced
this pull request
Jul 12, 2023
SystemError is used in two places: as a base class for SyncError, and for filesystem errors. Filesystem errors don't include the actual error message and need it appended, but sync errors do and appending the message from the error code just results in it being duplicated.
nicola-cab
pushed a commit
that referenced
this pull request
Jul 12, 2023
SystemError is used in two places: as a base class for SyncError, and for filesystem errors. Filesystem errors don't include the actual error message and need it appended, but sync errors do and appending the message from the error code just results in it being duplicated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SystemError is used in two places: as a base class for SyncError, and for filesystem errors. Filesystem errors don't include the actual error message and need it appended, but sync errors do and appending the message from the error code just results in it being duplicated.