Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting correct error message on HTTP errors for Emscripten target #6700

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

nhachicha
Copy link
Contributor

Currently, Http errors report as

[json.exception.parse_error.101] parse error at line 1, column 1: syntax error while parsing value - unexpected end of input; expected '[', '{', or a literal

This fixes the network transport for Emscripten to report errors properly

{"error":"password must be between 6 and 128 characters","error_code":"BadRequest","link":"https://realm.mongodb.com/groups/5d84ec2dcf09a2dcb343aa7a/apps/63d93da2dad7c0ff7cabdd5f/logs?co_id=6480656e2dac9d38f50821a5"}. Client Error: 400

@nhachicha nhachicha requested a review from fealebenpae June 7, 2023 11:35
@cla-bot cla-bot bot added the cla: yes label Jun 7, 2023
@nhachicha nhachicha requested a review from elle-j June 7, 2023 11:35
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is helpful!

@nhachicha nhachicha merged commit 9c31164 into master Jun 7, 2023
@nhachicha nhachicha deleted the nh/wasm/report_http_error branch June 7, 2023 12:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants