Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SessionWrapper use-after-free crash when tearing down sessions #6676

Merged
merged 23 commits into from
Jun 13, 2023
Merged

Fix SessionWrapper use-after-free crash when tearing down sessions #6676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c7f7899
Changed SessionWrapper pointer to bind_ptr; added session ident history
May 26, 2023
07cf26c
Updated changelog
May 26, 2023
e70045b
Fix teardown if client is destroyed before session
May 26, 2023
e265d80
Merge branch 'master' of github.com:realm/realm-core into mwb/fix-mul…
May 26, 2023
31317d5
Session no longer holds bind_ptr to SessionWrapper; reverted some cha…
May 26, 2023
8c0a1c1
Merge branch 'master' of github.com:realm/realm-core into mwb/fix-mul…
May 26, 2023
5fe095a
Updated changelog after release
May 26, 2023
253f951
Fixed return and updated some comments
May 26, 2023
68a1498
Don't process errors if session is shutting down
May 30, 2023
f2fee00
Merge branch 'master' of github.com:realm/realm-core into mwb/fix-mul…
May 31, 2023
356b169
Merge branch 'master' of github.com:realm/realm-core into mwb/fix-mul…
May 31, 2023
3781625
Added extra checks for session state
Jun 1, 2023
117e31a
Updates from review
Jun 5, 2023
5724ea4
Merge branch 'master' of github.com:realm/realm-core into mwb/fix-mul…
Jun 5, 2023
5075ead
Updated changelog after release
Jun 5, 2023
6352e17
Merge branch 'master' of github.com:realm/realm-core into mwb/fix-mul…
Jun 7, 2023
979fb56
Merge branch 'master' of github.com:realm/realm-core into mwb/fix-mul…
Jun 8, 2023
1e3c591
Updated some finalized checks
Jun 8, 2023
aca0feb
Rolled back some changes
Jun 8, 2023
011a17d
Added output to ASSERTS and moved session history to unordered_set
Jun 12, 2023
3f6cca0
Merge branch 'master' of github.com:realm/realm-core into mwb/fix-mul…
Jun 12, 2023
0ebefaf
Remove session history entry on normal close
Jun 12, 2023
f2caa2a
Updated comment in sync tests
Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

### Fixed
* <How do the end-user experience this issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?)
* None.
* Fix SessionWrapper use-after-free crash when tearing down sessions when using session multiplexing ([#6656](https://github.com/realm/realm-core/issues/6656), since v13.9.3)

### Breaking changes
* None.
Expand Down Expand Up @@ -51,7 +51,6 @@
* Fix the query parser, it needs to copy a list of arguments and own the memory. This will prevent errors like getting a different result from a query, if the list is modified after its creation and before the execution of the query itself. In the worst case scenario, if the memory is freed before the query is executed, this could lead to crashes, especially for string and binary data types. ([#6674](https://github.com/realm/realm-core/pull/6674), since v12.5.0)
* Fixed a potential crash when opening the realm after failing to download a fresh FLX realm during an automatic client reset ([#6494](https://github.com/realm/realm-core/issues/6494), since v12.3.0)


### Breaking changes
* None.

Expand Down
Loading