Bump the protocol version to v8 #6549
Conversation
CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| ### Enhancements | |||
| * <New feature description> (PR [#????](https://github.com/realm/realm-core/pull/????)) | |||
| * Improve performance of rolling back write transactions after making changes. If no KVO observers are used this is now constant time rather than taking time proportional to the number of changes to be rolled back. Rollbacks with KVO observers are 10-20% faster. ([PR #6513](https://github.com/realm/realm-core/pull/6513)) | |||
| * Enable PBS to FLX Migration feature that will migrate the local realm to use FLX if the server has been migrated to FLX. ([#6342](https://github.com/realm/realm-core/issues/6342)) | |||
There was a problem hiding this comment.
I think this entry should be about the feature itself (not about enabling a feature) and also a proper link to the feature
There was a problem hiding this comment.
Unfortunately, there isn't an issue specifically for the feature, since github issues aren't created for epics. I can update the comment to reflect the feature, rather than just enabling it..
There was a problem hiding this comment.
Maybe @bmunkholm can work some magic
| @@ -1588,6 +1588,13 @@ TEST_CASE("flx: writes work without waiting for sync", "[sync][flx][app]") { | |||
| }); | |||
| } | |||
|
|
|||
| TEST_CASE("flx: verify PBS/FLX websocket protocol number and prefix", "[sync][flx]") { | |||
| REQUIRE(8 == sync::get_current_protocol_version()); | |||
There was a problem hiding this comment.
this will break when we bump the version again. You should keep the initial assertion.
There was a problem hiding this comment.
This is a check to verify that the current protocol version is not updated unexpectedly - I added comments around these to make sure they are updated when the protocol version is bumped.
There was a problem hiding this comment.
Yes, my point is that going forward the checks should still be valid unless we make other changes to the prefix and we should then assert on the new version.
|
Are you also adding this test? |
Yes - in my local changes, I have added this to the second migrate and rollback in the |
CHANGELOG.md
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| ### Enhancements | |||
| * <New feature description> (PR [#????](https://github.com/realm/realm-core/pull/????)) | |||
| * None. | |||
| * PBS to FLX Migration for migrating a client app that uses partition based sync to use flexible sync under the hood if the server has been migrated to flexible sync. ([#6554](https://github.com/realm/realm-core/issues/6342)) | |||
There was a problem hiding this comment.
the link is not correct
What, How & Why?
Bump the sync protocol version to v8 and remove the compile flags for protocol v8.
Fixes #6342
Fixes #6554
☑️ ToDos
[ ] C-API, if public C++ API changed.