Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize sub-query only once #6328

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Initialize sub-query only once #6328

merged 2 commits into from
Feb 23, 2023

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Feb 22, 2023 •
edited
Loading

What, How & Why?

Fixes #6327

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@cla-bot cla-bot bot added the cla: yes label Feb 22, 2023
@jedelbo jedelbo requested a review from ironage February 22, 2023 13:38
@ironage
Copy link
Contributor

ironage commented Feb 22, 2023

I added a benchmark, feel free to modify it or merge as is.

SubqueryStrings (MemOnly, EncryptionOff) Release

  Req runs: Min Max Median Avg Stddev
Master 5 122ms 125ms 122ms 123ms 1ms
This branch 22 22ms 22ms 22ms 22ms 164us

ironage
ironage approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 💯

@jedelbo jedelbo merged commit 953d400 into master Feb 23, 2023
@jedelbo jedelbo deleted the je/fix-sub-query branch February 23, 2023 08:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ironage ironage ironage approved these changes

Assignees

@jedelbo jedelbo

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subquery performance is quite poor
2 participants
@jedelbo @ironage