Update yarn download path in install_baas.sh #6309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-wb
changed the title
jbreams
reviewed
Feb 15, 2023
| @@ -227,7 +227,7 @@ YARN="$WORK_PATH/yarn/bin/yarn" | |||
| if [[ ! -x "$YARN" ]]; then | |||
| echo "Getting yarn" | |||
| mkdir yarn && cd yarn | |||
| $CURL -LsS https://s3.amazonaws.com/stitch-artifacts/yarn/latest.tar.gz | tar -xz --strip-components=1 | |||
| $CURL -LsS https://yarnpkg.com/latest.tar.gz | tar -xz --strip-components=1 | |||
There was a problem hiding this comment.
do we want to put this in our S3 bucket that we use for other artifacts?
There was a problem hiding this comment.
I was wondering if we should pin the version on S3. The server team is updating their tests to use the official download path.
jbreams
approved these changes
Feb 15, 2023
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Yarn was failing to download from stitch-artifacts, since it had been moved to Glacier long term storage. Updated download path to use the official yarn download site: https://yarnpkg.com/latest.tar.gz
☑️ ToDos
[ ] 🚦 Tests (or not relevant)[ ] C-API, if public C++ API changed.