Pass callback and user data by value in realm_mongo_collection_<func> #6307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
approved these changes
Feb 15, 2023
2 tasks
nicola-cab
reviewed
Feb 15, 2023
| @@ -948,7 +948,7 @@ RLM_API bool realm_mongo_collection_find(realm_mongodb_collection_t* collection, | |||
| return wrap_err([&] { | |||
| collection->find_bson(convert_to_bson<bson::BsonDocument>(filter_ejson), | |||
| to_mongodb_collection_find_options(options), | |||
| [&](util::Optional<bson::Bson> bson, util::Optional<AppError> app_error) { | |||
| [=](util::Optional<bson::Bson> bson, util::Optional<AppError> app_error) { | |||
There was a problem hiding this comment.
Only a minimal thing, I think the only thing you need to capture by copy is the callback, the rest of the data can be passed by reference. Although in 99% of the case, we are copying a ptr (thus equivalent to passing the arguments by reference), for realm_string_t filter_ejson we will be copying sizeof(ptr) + sizeof(size_t) bytes.
Not a big issue, since the amount of data copied will always be constant.
There was a problem hiding this comment.
I need to pass by value data, delete_data and callback. Otherwise when I receive the callback I can't access the data object. I can change it to [data, delete_data, callback] instead of [=], if you say that it is better.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the C-API functions like
realm_mongo_collection_find,realm_mongo_collection_find_oneand so on.The callback can not be found if its pointer is passed by reference.
It was not handled because the tests in
realm-coredon't call these methods with passing callbacks as arguments.Related to the implementation in realm/realm-dart#1162
What, How & Why?
☑️ ToDos
[ ] 📝 Changelog update[ ] 🚦 Tests (or not relevant)[ ] C-API, if public C++ API changed.