Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sync benchmarks #6281

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Fix sync benchmarks #6281

merged 2 commits into from
Feb 6, 2023

Conversation

jbreams
Copy link
Contributor

@jbreams jbreams commented Feb 6, 2023 •
edited
Loading

What, How & Why?

This updates our sync benchmarks to detach any sessions before explicitly stopping/draining their associated sync clients. I updated the evergreen build to build/run the benchmarks as part of the testing for this PR.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@cla-bot cla-bot bot added the cla: yes label Feb 6, 2023
@jbreams jbreams marked this pull request as ready for review February 6, 2023 22:27
michael-wb
michael-wb approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@michael-wb michael-wb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - already three of the benchmark-sync tests have passed, which were failing/timing out before.

@jbreams jbreams merged commit 0c360d0 into master Feb 6, 2023
@jbreams jbreams deleted the jbr/fix_benchmarks branch February 6, 2023 22:57
@kiburtse kiburtse mentioned this pull request Mar 3, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danieltabacaru danieltabacaru danieltabacaru approved these changes

@michael-wb michael-wb michael-wb approved these changes

Assignees

@jbreams jbreams

Labels
cla: yes no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbreams @danieltabacaru @michael-wb