Fix default enabled debug output during realm-sync-tests #6234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
reviewed
Jan 25, 2023
test/util/unit_test.cpp
Outdated
| @@ -413,29 +413,22 @@ class WildcardFilter : public Filter { | |||
| class IntraTestLogger : public Logger { | |||
| public: | |||
| // Logger with a local log level used for the different test threads | |||
| // A new log level threshold atomic will be used for this logger, but | |||
| // it will write to the base_logger_ptr when do_log() is called | |||
| IntraTestLogger(const std::shared_ptr<Logger>& base_logger_ptr, Level threshold) | |||
There was a problem hiding this comment.
can you write a real quick little test that instantiates an IntraTestLogger at like trace or debug level and then verify that it actually respects that?
There was a problem hiding this comment.
Added test, but I needed to move the IntraTestLogger to logger.hpp - I renamed the class to LocalThresholdLogger
jbreams
approved these changes
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
When the log level threshold was updated to be atomic, the
IntraTestLoggerwas updated to provide its own log level threshold, but this value was not being used properly by subsequent loggers that were linked to this object. An instance of theIntraTestLoggeris used by each of the test threads in a unit test run to prevent changes in one thread from affecting the other threads, but they all print out using a single root logger (protected by aThreadSafeLogger) that is created when the test is started.Fix the level threshold in the
IntraTestLoggerso it has its own atomic log level threshold that is used by linked loggers.Fixes #6233
☑️ ToDos
[ ] C-API, if public C++ API changed.