Fix an invalid use of frozen Realms in client reset #6230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turned out to not be the source of the problem I was looking in to, but `get_realm(config, VersionID())` does strange and invalid things that appears to work in simple cases but can cause weird problems. VersionID() is turned into an actual version only when acquiring a read lock, and won't turn into the same version every time for a given frozen Realm.
jbreams
approved these changes
Jan 24, 2023
|
@tgoyne Not possible to easily add a test for I assume? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to not be the source of the problem I was looking in to, but
get_realm(config, VersionID())does strange and invalid things that appears to work in simple cases but can cause weird problems. VersionID() is turned into an actual version only when acquiring a read lock, and won't turn into the same version every time for a given frozen Realm.