Fix version corruption during client reset with recovery with a single FLX subscription #6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironage
approved these changes
Jan 4, 2023
| @@ -612,7 +611,7 @@ LocalVersionIDs perform_client_reset_diff(DBRef db_local, DBRef db_remote, sync: | |||
| // partially recovered, but interrupted may continue sync the next time it is | |||
| // opened with only partially recovered state while having lost the history of any | |||
| // offline modifications. | |||
| history_local->set_client_file_ident_in_wt(current_version_local, client_file_ident); | |||
| history_local->set_client_file_ident_in_wt(wt_local->get_version(), client_file_ident); | |||
…covery_version_corruption
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This fixes a crash if client reset with recovery is used when flexible sync is enabled and there is only one subscription set defined. For a write-up of how the crash occurs, see #6070.
☑️ ToDos