Change interface of realm_sync_immediately_run_file_actions to report… #6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsenko
force-pushed
the
kn/fix-realm_sync_immediately_run_file_actions
branch
from
1944f44 to
f60b36b
Compare
fealebenpae
approved these changes
Dec 14, 2022
blagoev
approved these changes
Dec 14, 2022
|
@nielsenko will need a change in the tests as well |
nicola-cab
approved these changes
Dec 14, 2022
nielsenko
force-pushed
the
kn/fix-realm_sync_immediately_run_file_actions
branch
from
505f0e9 to
d38b8cb
Compare
|
Note that due to #6050, you may continue seeing issues with manual reset. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change C-api to actually report success or failure of
SyncManager::immediately_run_file_actions. The return value is reserved for reporting exceptions, so result is reported on a new thirdbool* did_runargument.☑️ ToDos