Use target_link_options to set -fuse-ld flag #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that anything that transitively links to Realm::Storage will pick up this flag automatically. Due to how cmake handles target options, this will also be appended to the linker command line *after* anything set using add_link_options(), including the -fuse-ld=gold from our OpenSSL prebuilt.
RedBeard0531
commented
Nov 18, 2022
| @@ -1,6 +1,6 @@ | |||
| macro(build_fuzzer_variant variant) | |||
| add_executable(${variant} command_file.hpp command_file.cpp ${variant}.cpp) | |||
| target_link_libraries(${variant} realm-object-store) | |||
| target_link_libraries(${variant} ObjectStore) | |||
There was a problem hiding this comment.
By specifying the library name rather than the cmake target this was bypassing flag propagation. I didn't think that was intentional, so I change it to use the target name.
| @@ -319,6 +319,9 @@ set_target_properties(Storage PROPERTIES | |||
| ) | |||
|
|
|||
| target_compile_options(Storage PUBLIC ${REALM_SANITIZER_FLAGS}) | |||
There was a problem hiding this comment.
It seems weird that we are doing this unconditionally, but then doing it again on line 331 inside an if(NOT MSVC) block. But I didn't want to change that as part of this commit. 🤷
fealebenpae
approved these changes
Nov 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that anything that transitively links to Realm::Storage will pick up this flag automatically. Due to how cmake handles target options, this will also be appended to the linker command line after anything set using add_link_options(), including the -fuse-ld=gold from our OpenSSL prebuilt.
I manually verified that if I point realm-js's submodule to this commit, it will start using lld for linking.
What, How & Why?
☑️ ToDos
[ ] 🚦 Tests (or not relevant)[ ] C-API, if public C++ API changed.