Expose Obj::get_parent_object in the C API
#5851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
approved these changes
Sep 13, 2022
nirinchev
reviewed
Sep 13, 2022
Comment on lines
+34
to
+35
| if (parent) | ||
| *parent = realm_object_t{realm::Object{object->get_realm(), object->obj().get_parent_object()}}; |
There was a problem hiding this comment.
I've seen the C API littered with these types of checks and I'm no sure I understand their purpose. Not supplying a pointer to store the parent in sounds like a fundamental error in using the API. I'd rather have this be an assert than the method silently not doing anything.
There was a problem hiding this comment.
I agree, but it is important we keep the same pattern, I can clean all this up in a separate PR.
Co-authored-by: Yavor Georgiev <[email protected]>
jedelbo
approved these changes
Sep 14, 2022
jedelbo
requested changes
Sep 14, 2022
| @@ -244,11 +244,15 @@ RLM_API realm_query_t* realm_query_parse_for_list(const realm_list_t* list, cons | |||
| const realm_query_arg_t* args) | |||
| { | |||
| return wrap_err([&]() { | |||
| auto existing_query = list->get_query(); | |||
There was a problem hiding this comment.
I guess this is part of another PR
There was a problem hiding this comment.
oh yes sorry, I have multiple small PRs open... my bad. let me revert this..
There was a problem hiding this comment.
Code has been reverted
This reverts commit 47ff44b.
…m-core into nc/expose_object_parent_c_api
jedelbo
approved these changes
Sep 14, 2022
tgoyne
added a commit
that referenced
this pull request
Sep 16, 2022
…nification * origin/master: Stop forcing enums to be 64 bits unnecessarily clean up documentation of internal fields in config structs SyncConfig should be default constructible Traversal functions use IteratorControl values rather than true/false which is more expressive (#5857) Fix handling of 4-byte UTF8 values on Windows (#5803) Encode links in a way the server can understand (#5835) expose `Group::remove_table` in the C API (#5860) Disable auto refresh for old realm during migration (#5856) Expose `list_find` in the c api (#5848) Do not allow asymmetric tables in pbs (#5853) Refactor link tracing code (#5796) Expose `Obj::get_parent_object` in the C API (#5851) Update app.hpp (#5854) Fix appending to list ignores existing query (#5850)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fixes: #5837
☑️ ToDos