Detect sync termination with new endpoints #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
force-pushed
the
jbr/fix_sync_enabled_endpoints
branch
from
b4d7cdb to
77c7ca1
Compare
ironage
approved these changes
Sep 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
When terminating sync as part of our client reset tests, we need to wait for sync to actually terminate before we can re-enable it. This change adds a new API for querying whether sync is terminated and makes the client reset test harnesses wait for it to report sync being fully terminated.
☑️ ToDos
* [ ] 🚦 Tests (or not relevant)The test here is whether all our failing tests pass again.