Wait for download completion when downloading fresh FLX realm in client reset #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, yes this should be the only place needing an update for client resets 👍 |
jbreams
force-pushed
the
jbr/client_resets_full_sync
branch
from
c71c5dc to
768958e
Compare
ironage
approved these changes
Sep 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This is a stop-gap fix for #5705 that makes it so that downloading a fresh realm waits for download completion when handling a client reset with FLX sync. @ironage is there anywhere else that we'd need to add a wait_for_download_completion?
☑️ ToDos
* [ ] 🚦 Tests (or not relevant)* [ ] C-API, if public C++ API changed.