Do not allow migrations with asymmetric tables #5603
Conversation
|
Can you rebase this onto latest master to fix all the object-store-tests? |
danieltabacaru
force-pushed
the
dt/disallow_migrations_with_asymmetric_tables
branch
from
02a0584 to
774161d
Compare
| @@ -423,9 +423,12 @@ static inline realm_class_info_t to_capi(const ObjectSchema& o) | |||
| info.num_properties = o.persisted_properties.size(); | |||
| info.num_computed_properties = o.computed_properties.size(); | |||
| info.key = o.table_key.value; | |||
| if (o.is_embedded) { | |||
| if (o.table_type == ObjectSchema::TableType::Embedded) { | |||
There was a problem hiding this comment.
should this just be a switch statement?
| o << "TopLevelAsymmetric"; | ||
| break; | ||
| default: | ||
| o << "Unknown table type"; |
There was a problem hiding this comment.
If this isn't just going to be REALM_UNREACHABLE, do we want to output the value as an integer here for debugging purposes?
| using IsAsymmetric = util::TaggedBool<class IsAsymmetricTag>; | ||
| /// The type of tables supported by a realm. | ||
| /// Note: Enumeration value assignments must be kept in sync with <realm/table.hpp>. | ||
| enum class TableType : uint8_t { TopLevel = 0, Embedded = 0x1, TopLevelAsymmetric = 0x2 }; |
There was a problem hiding this comment.
should we add a static_assert in the implementation file that verifies the values match? Is the reason we don't want to just use the actual Table::Type enum here that we don't want to pull in table.hpp as an include in this file?
also, from a naming perspective. should this really be ObjectType rather than TableType at the ObjectStore layer?
There was a problem hiding this comment.
I don't have a strong opinion on the name (as a fact I wasn't happy with it), but I think ObjectType makes more sense.
The reason is that since some SDKs interface with OS directly, I find it a bit weird that they would need to know about table.hpp and Table::Type when creating schemas (I want everything doing with schemas to be contained in object_schema.hpp).
danieltabacaru
force-pushed
the
dt/disallow_migrations_with_asymmetric_tables
branch
from
b01d99a to
f05db09
Compare
What, How & Why?
This PR fixes and improves several things around asymmetric sync.
Fixes RCORE-1120.
(Commits are logically separated to make review easier)
☑️ ToDos
[ ] C-API, if public C++ API changed.