Fix a data race on write_validator_factory #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PendingBootstrapStore is created early in session initialization, which performs a write and thus reads the write validator. This can race with setting the write validator on the thread which created the sync session, and tsan complains about it. Moving the initialization to SyncSession's constructor ensures that it's set before we create the `sync::Session`.
jbreams
approved these changes
Jun 8, 2022
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| ### Fixed | |||
| * Fixed a segfault in sync compiled by MSVC 2022. ([#5557](https://github.com/realm/realm-core/pull/5557), since 12.1.0) | |||
| * Fix a data race when openg a flexible sync Realm (since v12.1.0). | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PendingBootstrapStore is created early in session initialization, which performs a write and thus reads the write validator. This can race with setting the write validator on the thread which created the sync session, and tsan complains about it.
Moving the initialization to SyncSession's constructor ensures that it's set before we create the
sync::Session.