Allow embedded objects with asymmetric sync #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
reviewed
Jun 7, 2022
test/object-store/sync/flx_sync.cpp
Outdated
| CppContext c(realm); | ||
| Object::create( | ||
| c, realm, "Asymmetric", | ||
| util::Any(AnyDict{{"_id", ObjectId::gen()}, {"embedded_obj", AnyDict{{"value", std::string{"foo"}}}}})); |
There was a problem hiding this comment.
I know this will exercise the create/set link codepaths, but can we add a test here that updates the embedded field to null and then to a new embedded field as well?
There was a problem hiding this comment.
sure. I'll add that
jbreams
approved these changes
Jun 8, 2022
| }); | ||
|
|
||
| harness.do_with_new_realm([&](SharedRealm realm) { | ||
| wait_for_download(*realm); |
There was a problem hiding this comment.
since there aren't any subscriptions here, isn't this a no-op?
There was a problem hiding this comment.
correct. But it's just to make sure that if for example the server would do something weird, we don't get any objects.
|
@jedelbo , can you take a look as well? |
jedelbo
approved these changes
Jun 10, 2022
src/realm/obj.cpp
Outdated
| get_table()->check_column(col_key); | ||
| ColKey::Idx col_ndx = col_key.get_index(); | ||
| ColumnType type = col_key.get_type(); | ||
| if (type != col_type_Link) | ||
| throw LogicError(LogicError::illegal_type); | ||
| TableRef target_table = get_target_table(col_key); | ||
| Table& t = *target_table; | ||
| // Outgoing links from asymmetric objects are disallowed. |
There was a problem hiding this comment.
Perhaps "Only embedded objects are allowed"
danieltabacaru
force-pushed
the
dt/allow_embedded_objects_with_asymmetric_sync
branch
from
2e796bf to
974b390
Compare
danieltabacaru
deleted the
dt/allow_embedded_objects_with_asymmetric_sync
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Embedded objects were wrongly not allowed in asymmetric sync. This PR addresses that.
Fixes #5565.
☑️ ToDos
[ ] C-API, if public C++ API changed.