Update FLX subscription state after reporting sync progress #5553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
force-pushed
the
jbr/update_flx_after_progress
branch
from
7672a97 to
e1333fa
Compare
Merged
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
In #5331 the order in which we report FLX subscription state changes and report sync progress was changed for bootstrap messages. This has had some unintended consequences around when/how the realm gets refreshed with newly bootstrapped data. This change just restores the previous behavior.
This also ensures that the sync transact notifier gets called for bootstrap messages.
Finally it updates the basic FLX sync lifecycle test to not rely on calling refresh().
☑️ ToDos