Fix possibly missing parent update when setting null values #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedelbo
force-pushed
the
je/fix-mising-parent-update
branch
from
0711d4e to
6b89fea
Compare
bmunkholm
reviewed
Mar 17, 2022
| @@ -1774,7 +1774,7 @@ inline void nullify_set(Obj& obj, ColKey origin_col_key, T target) | |||
|
|
|||
| void Obj::nullify_link(ColKey origin_col_key, ObjLink target_link) | |||
| { | |||
| ensure_writeable(); | |||
| // ensure_writeable(); | |||
There was a problem hiding this comment.
@jedelbo shouldn't this be deleted or an explanation added?
There was a problem hiding this comment.
This can be deleted. Just forgot.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fixes #5283
The result is that a cluster is not updated, but still points to a location in the slab area that has been freed and hence has some parts overwritten. This happens when an already writable cluster array has to expand on width when a property is set to null. This can happen when the file grows towards 2 Gb in size and the table has more than 16 columns, but perhaps also when the file grows towards 32 kb and the table has more than 32 columns, but it has to be investigated further.
Also potentially fixes other corruption bugs.
☑️ ToDos