Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DiscardLocal client reset failure with unset callbacks #5228

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

ironage
Copy link
Contributor

@ironage ironage commented Feb 8, 2022

Fixes #5223
I forgot to check a function before calling it. I think SDKs other than cocoa have these always set because they wrap them up in a SDK layer callback so are likely not affected.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)

@ironage ironage requested review from jbreams and ejm01 February 8, 2022 02:05
@ironage ironage self-assigned this Feb 8, 2022
@cla-bot cla-bot bot added the cla: yes label Feb 8, 2022
Copy link
Contributor

@ejm01 ejm01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code factor says "Complex Method"?
And a seemingly unrelated test has Command failed: couldn't read report file '/data/mci/bdfc013337a55c1faabd97af1ec7bd4f/realm-core/object-store-tests_results.json': unexpected end of JSON input?

Otherwise everything LGTM.

@ironage
Copy link
Contributor Author

ironage commented Feb 8, 2022

I fixed the complexity issue by refactoring a bit. I reluctantly agree that CodeFactor was helpful here.

@ironage ironage merged commit b7520e1 into master Feb 8, 2022
@ironage ironage deleted the js/reset-no-notify branch February 8, 2022 22:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash during client reset if notify_after_client_reset or notify_before_client_reset are nil.
3 participants