Fix an error when compiling a watchOS target not supporting Thread-local storage. #5188
Conversation
src/realm/impl/simulated_failure.cpp
Outdated
| @@ -168,7 +168,7 @@ bool SimulatedFailure::do_check_trigger(FailureType failure_type) noexcept | |||
| return false; | |||
| } | |||
|
|
|||
| #if REALM_ARCHITECTURE_X86_32 && REALM_IOS | |||
| #if (REALM_ARCHITECTURE_X86_32 && REALM_IOS) || REALM_WATCHOS | |||
There was a problem hiding this comment.
This is related to #5102. I am going to make a guess and say that we should probably include REALM_TVOS as well. Alternatively, we already have a RLM_NO_THREAD_LOCAL which we could move to features.h so it could be used here as well.
There was a problem hiding this comment.
The second option will help to avoid this to happen in other targets that we are not counting on, so will be a better solution to this issue. I can do it on this PR if we agree on this approach.?
There was a problem hiding this comment.
I tested this approach but seems that it doesn't work for this particular scenario
There was a problem hiding this comment.
RLM_NO_THREAD_LOCAL is equal to REALM_PLATFORM_APPLE, which doesn't seem like a correct definition.
There was a problem hiding this comment.
Is thread-local storage actually not supported at all on watchOS? I would have expected it to be supported on 64-bit watchOS.
There was a problem hiding this comment.
It Is not supported on the simulator, device architecture should be arm64_32 which I just read should support it
I could just check for simulator architecture
(REALM_ARCHITECTURE_X86_64 && REALM_WATCHOS)
or just for for architecture
REALM_ARCHITECTURE_X86_64
I'm not sure if the availability only depends of the architecture and/or platform.
Fix an error when compiling a watchOS target not supporting Thread-local storage. (#7623)
What, How & Why?
☑️ ToDos