Prevent UserIdentity metadata table from growing #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ironage if you agree that this was not then intention, I will also create an issue for it. |
|
Yes great find, and the fix you made is solid. Another approach to get the expected behaviour could be to make the UserIdentity an embedded table such that clearing the list also deletes the linked objects. But I'm not sure if the limitations of embedded tables will hinder us from using this data in the future so I think your solution is probably best. |
jedelbo
force-pushed
the
je/user-identity
branch
from
6e0cec2 to
8d4a209
Compare
jsflax
approved these changes
Jan 11, 2022
jedelbo
force-pushed
the
je/user-identity
branch
from
ec73d3b to
151353e
Compare
jedelbo
force-pushed
the
je/user-identity
branch
from
151353e to
13bbcc0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
I discovered that every time I ran a realm-js program using a synchronized realm, the UserIdentity table was growing with 2 elements, but all elements in the table were the same.
Fixes #5152
☑️ ToDos