Feature/convert local realm #5136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The limit is 100 in debug builds and 1000 in release builds.
Instead of storing change sets in a history, the changes are done directly to a write transaction given as parameter.
|
@jedelbo Please remember to link to the issue it resolves. |
ironage
approved these changes
Jan 6, 2022
src/realm/impl/copy_replication.cpp
Outdated
| table->add_column_dictionary(type, name, col_key.is_nullable(), key_type); | ||
| } | ||
| else { | ||
| table->add_column(type, name, col_key.is_nullable()); |
There was a problem hiding this comment.
can we add an index to the new column if it exists in the source table?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
"Convert local to synced realm" feature
Fixes #5018
☑️ ToDos