Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Object::set_property_value(ContextType&, const Property&, ValueType, CreatePolicy) #5011

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Nov 1, 2021

What, How & Why?

Realm JavaScript is performing the same lookup, so the proposed method will make it possible to avoid the additional lookup.

Related to realm/realm-js#4058

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)

…pe, CreatePolicy) for SDKs which have performed the property lookup
@cla-bot cla-bot bot added the cla: yes label Nov 1, 2021
@kneth kneth self-assigned this Nov 1, 2021
@kneth kneth requested a review from jedelbo November 1, 2021 13:13
@kneth kneth mentioned this pull request Nov 1, 2021
1 task
@kneth kneth force-pushed the kneth/addition-setters-and-getters branch from f41156b to a707971 Compare November 1, 2021 15:17
Copy link
Contributor

@jedelbo jedelbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Strange this was missing.

@kneth kneth merged commit 23137f2 into master Nov 3, 2021
@kneth kneth deleted the kneth/addition-setters-and-getters branch November 3, 2021 09:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants