Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create custom error code for InvalidPassword response #4851

Merged
merged 3 commits into from
Aug 18, 2021
Merged

Create custom error code for InvalidPassword response #4851

merged 3 commits into from
Aug 18, 2021

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Aug 18, 2021 •
edited
Loading

What, How & Why?

Fixes #4581

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)

@jedelbo jedelbo requested a review from jbreams August 18, 2021 18:01
@jedelbo jedelbo marked this pull request as ready for review August 18, 2021 18:01
ironage
ironage approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could add a note in the change log about fixing #4581

@jedelbo jedelbo merged commit bc53af9 into master Aug 18, 2021
@jedelbo jedelbo deleted the je/RCORE-648 branch August 18, 2021 19:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ironage ironage ironage approved these changes

@jbreams jbreams jbreams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add error code for "invalid email/password"
3 participants
@jedelbo @jbreams @ironage