fix an edge case of embedded table migrations #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicFrei
approved these changes
May 14, 2021
There was a problem hiding this comment.
Nice one! Checked against the example provided in realm/realm-swift#7248 which now correctly fails with the 'objects with no backlinks' error for the orphaned objects in there instead of showing 'too many backlinks'.
tgoyne
approved these changes
May 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a report of migrating to an embedded table not working when it should. Debugging revealed that the changed to embedded was being processed before a link column which pointed to the table was removed. Removing the link column first will remove the incoming links which allows the embedded change to succeed.
☑️ ToDos